fish-shell icon indicating copy to clipboard operation
fish-shell copied to clipboard

io: retry writes on interrupts

Open danielrainer opened this issue 2 months ago • 2 comments

Interrupts should not prevent output from being completed, unless they result in control flow not continuing where it was interrupted.

Return results containing errors, so callers have more options for error handling. Returning the number of bytes written on success is no longer necessary, since success now means that all input bytes were written.

In src/io.rs some changes are needed since EINTR is no longer a possible return value. I also removed the comments on the old code and the sigcheck code. Not sure if this should be kept.

danielrainer avatar Oct 30 '25 17:10 danielrainer

The Fluent PR no longer depends on this, so there is no immediate need to get these changes merged. If you'd like, we can just close this PR. I don't think I'll look much more into this any time soon.

danielrainer avatar Nov 20 '25 02:11 danielrainer

The Fluent PR no longer depends on this, so there is no immediate need to get these changes merged. If you'd like, we can just close this PR. I don't think I'll look much more into this any time soon.

there's different opinions on how to manage the PR/issue list. I don't really care either way (since I can additionally keep my private todo-list)

I'd keep it open because at least the bug (?) about fish_indent not being cancelable (which is not reported elsewhere yet AFAIK) should have an obvious fix, and then we can figure out if the other things.

krobelus avatar Nov 22 '25 15:11 krobelus