fish-shell icon indicating copy to clipboard operation
fish-shell copied to clipboard

Bravely revert "CI: Disable some Cirrus CI jobs during RIIR transition"

Open zanchey opened this issue 2 months ago • 3 comments

Test this actually works on Cirrus

zanchey avatar Oct 05 '25 11:10 zanchey

TODO: need to either re-revert b1e8fdfaa2c (Revert "CI: use build_tools/check.sh in Cirrus CI", 2025-10-06), or keep using cmake (I have not had time to figure out what was the problem; some of them symptoms are documented in the commits I pushed to this PR).

The fact that .github/workflows/docker_builds.yml only writes to a central registry that's directly used by master is not ideal; maybe we can set things up so it's easy to test everything in a temporary branch, e.g. by allowing workflow_dispatch triggers to use a custom docker registry namespace

krobelus avatar Oct 06 '25 11:10 krobelus

The fact that .github/workflows/docker_builds.yml only writes to a central registry that's directly used by master is not ideal; maybe we can set things up so it's easy to test everything in a temporary branch, e.g. by allowing workflow_dispatch triggers to use a custom docker registry namespace

You can test it in your own fork and it will write to your own package registry. A dispatch trigger would be a fine thing to add.

I was going to poke at this some more but it looks like you want to take it over?

zanchey avatar Oct 07 '25 14:10 zanchey

You can test it in your own fork and it will write to your own package registry

right, that should work (probably some of the ones in https://github.com/krobelus/fish-shell/actions/runs/18277577848 failed because I had never pushed those images before, so I get a permissions error).

I was going to poke at this some more but it looks like you want to take it over?

Feel free to take it back (and drop the bad commit that's unrelated to Cirrus). We could stick with cmake for now, to keep it close to current GitHub actions, but check.sh should work, and might be easier because I already removed CMake from the docker images

krobelus avatar Oct 07 '25 14:10 krobelus