react-three-renderer Ensure that shouldComponentUpdate gets called with the correct new / old props

Ensure that shouldComponentUpdate gets called with the correct new / old props

Open toxicFork opened this issue 9 years ago • 4 comments

Apr 18 '16 14:04 toxicFork

What's the status on this? ~~It would be very nice to have calls to shouldComponentUpdate()~~

Edit: Seems I was using the PureRenderMixin...removing this gives me calls to shouldComponentUpdate() as expected

May 19 '16 07:05 dankirkpatrick

Hi, I will have a bit more time for the project this weekend, I will be able to write the tests for this issue too :)

May 19 '16 08:05 toxicFork

@dankirkpatrick do the old/new props appear correct to you? If not I'll move it higher up in my TODO :)

May 19 '16 17:05 toxicFork

So far it looks good. My problem was self-inflicted :-)

May 20 '16 07:05 dankirkpatrick