react-three-renderer
react-three-renderer copied to clipboard
firtoz
React v 16.0.0 support
Hi, are there any plans to support React 16.0.0? After updating I've got an error:
Module not found: Can't resolve 'react/lib/ReactComponentWithPureRenderMixin' in '/home/project/frontend/node_modules/react-three-renderer/lib'
If so - are there any ETA?
Plans : yes :) I really want that to happen, and I know it's possible.
ETA : not very soon :( it's going to be a full rewrite.
See: https://github.com/toxicFork/react-three-renderer-fiber
On Fri, Sep 29, 2017, 10:29 Marek Oleksiak [email protected] wrote:
Hi, are there any plans to support React 16.0.0? After updating I've got an error:
Module not found: Can't resolve 'react/lib/ReactComponentWithPureRenderMixin' in '/home/project/frontend/node_modules/react-three-renderer/lib'
If so - are there any ETA?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/issues/197, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLZ3kAhcXjA4V7XG33rZJI6JtixAgks5snLiIgaJpZM4PobBH .
Hi, be interesting to know if using fibre and your react-three-renderer-fiber might help with #127 and how else it might fundamentally affect R3R usability / extensibility? Would it be backwards compatible (if it's not there may be opportunities to make it more Typescript friendly!).
some specific research will still need to be done e.g. To have typescript compatibility with custom renderers. I'm guessing some sort of tool to take component types, attribute types to generate tsd output for "new natives"?
Hi, for better Typescript support there are a couple of things needed:
- TSD file needs to be created. This can be hand-crafted, generated from jsdoc, or you can code in Typescript from the outset and the compiler will generate the tsd file for you (
tsc -d) - The problem with lowercased intrinsic elements needs to be solved. I don't know if there is a solution actually, so I wonder if using initial caps for R3R elements is a possibility. Obviously this would be a breaking change so can understand it might not fly!
Thanks
Good news, I will be doing the fiber implementation in typescript
Expect a branch to surface soon :)
I have fixed part of the tsd problems for intrinsic types, it's looking sweeet
On Sat, Sep 30, 2017, 15:34 jugglingcats [email protected] wrote:
Hi, for better Typescript support there are a couple of things needed:
- TSD file needs to be created. This can be hand-crafted, generated from jsdoc, or you can code in Typescript from the outset and the compiler will generate the tsd file for you (tsc -d)
- The problem with lowercased intrinsic elements needs to be solved. I don't know if there is a solution actually, so I wonder if using initial caps for R3R elements is a possibility. Obviously this would be a breaking change so can understand it might not fly!
Thanks
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/issues/197#issuecomment-333312425, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLZsPhN1cPS15vovRYGXoLs7xk19nks5snlFhgaJpZM4PobBH .
@toxicFork Good news on fiber implementation, but may I ask, whats the motivation for using typescript for new implementation? I suspect that code base ends up less approachable for contributors as majority devs deal just with javascript.
Once I added the type checking it makes it so much faster and easier to make something that works!
Especially when dealing with such uncharted territory (at least for myself), having the type hints is a really good support.
Yes, unfortunately it will mean making it harder for contributors... that's indeed a problem. I'm hoping it won't be "too hardcore typescript" at least :)
@toxicFork On different note. Do you think that it would be feasible to make new implementation somewhat modular, similarly as current Three.js? It would be awesome if would be possible to avoid bundling complete Three.js and r3r when using only few elements.
@toxicFork And is not flow more suitable since react use that? There is discussion about exposing react reconciler and there is definitely intention to include flow types for that api.
Disclaimer: I don't have personal experience with neither flow or typescript.
I considered flow and sided with TypeScript, as it has more benefits. If something works with flow it should also work with TS anyway, and also thank you for linking to that discussion, I had to link to my own build of the fiber reconciler to do some testing :D
https://github.com/facebook/react/pull/10758 just landed! I'm going to give it a try and feed information back to fb to help resolve potential problems, meanwhile I'm also redesigning parts of the core to make more sense... Exciting times.
https://www.npmjs.com/package/react-reconciler still at v0 (i.e. not published) but once it's out I'll post an update here :)
I have subscribed to https://github.com/facebook/react/issues/9103 so I'm guessing that one will be closed once the publishing happens.
react-reconciler 0.2.0 is available (together with React 16.1 beta) (react-konva is already using it and it looks like its working alright).
Related: https://github.com/toxicFork/react-three-renderer-fiber/issues/24
@toxicFork Hey, just wondering, do you have any update on react-three-rendered-fiber progress? The repo seems quiet lately :-).
Hi, apologies on the quietness, having another chaotic period. I'm not sure when things will cool down, I'm hoping for sometime in January.
@toxicFork Have you pushed all the code you have locally? It'd be fun to experiment with.
Just checked my repos and it is up to date for react-three-renderer,
https://github.com/toxicFork/react-three-renderer-fiber
It looks like I had branched off to "create-react-renderer" to allow making "any kind of custom react renderer" with a similar file structure, but that's a distraction I should have prevented. Depends on what the end goal is.
That distraction is in https://github.com/toxicFork/react-three-renderer-fiber/commits/create-react-renderer .
And the diff in https://github.com/toxicFork/react-three-renderer-fiber/compare/create-react-renderer?expand=1
@toxicFork Which branch is better to play with, continue development on: master or the "distraction" branch, create-react-renderer? Do you plan to abandon the "distraction"?
I'll probably merge it into master as it should be mostly compatible, then eventually split into another repo and make r3r use "create react renderer". But yes, to decide is hard. Ideally: finish r3r first.
So, master.
On Tue, Dec 12, 2017, 10:12 Ivan Babak [email protected] wrote:
@toxicFork https://github.com/toxicfork Which branch is better to play with, continue development on: master or the "distraction" branch, create-react-renderer? Do you plan to abandon the "distraction"?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/issues/197#issuecomment-351006200, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLSpHplbHZE2TkVMaYIFKIPcrgKOyks5s_lGQgaJpZM4PobBH .
@toxicFork what the current plan for this repo?
Is R3R no usable at all with React 16?
I'm looking for react 16 comparability as well. Really frustrated to not have it with this library. I understand that it's a fairly large overhaul to get it working well with fibers.
@toxicFork Do you have any updates on react-three-renderer-fiber? Would be good to know if that has stalled or not.
To be realistic it is pretty much stalled, the foundation is there, but need to implement the components and so on which is taking a long time.
This is because the full time projects I am involved with lately - the ones which allow myself to be fed - do not use React as much as my previous endeavours, and it is getting harder and harder to switch context.
I apologize for the lack of transparency on the project's status, I myself am quite frustrated with this situation too.
On Wed, Jun 6, 2018, 19:46 Nick Polet [email protected] wrote:
I'm looking for react 16 comparability as well. Really frustrated to not have it with this library. I understand that it's a fairly large overhaul to get it working well with fibers.
@toxicFork https://github.com/toxicFork Do you have any updates on react-three-renderer-fiber? Would be good to know if that has stalled or not.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/toxicFork/react-three-renderer/issues/197#issuecomment-395173688, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0iLccbnBvks37Ju8_CmSwAnbxdkxd4ks5t6CNzgaJpZM4PobBH .
Hey @Aarbel, thank you for your interest in the project. I'm hoping for some time this year, but the development is very on and off at this point so it's quite hard to make estimates unfortunately.
@toxicFork I'm unfortunately going to have to stop using this library if a React 16 update doesn't happen soon. There are other libraries (like material-ui) that now only work with React 16 and it's difficult to balance with legacy React.
