firsttris
replace deprecated function listItem.setInfo()
should fix: https://github.com/firsttris/plugin.video.sendtokodi/issues/92
I am currently not able to test the changes but based on quick research this will break support for everything before Kodi 20. But I am not 100 % certain, somebody else might want to clarify this. For me this would be welcomed as it would allow us to get rid of the python2 compatibility quirks (no second repo, using python3 features etc.) - but I am not the only one and there still might be people on 18/19. Just wanted to let you know :)
Makes the most sense for me as well but maybe another PR should first get rid of the workflow etc. for the python2 repo? In that case the lost soul still using python2 could at least use the latest published addon until the resolver breaks due to website changes. Otherwise this pr would cause an update an break the addon for python2 immediately.
I'm that lost soul
Kodi 17.6 on Debian 10 on an 32 bit Intel Atom netbook with OpenGL 1.4 support. The perfect kitchen youtube player 🙂
What can I say? It's cute. This and ScummVM are its last hope (I even built Kodi 17.6 for Debian 10 for it). I guess I'll have to start hooking into the system's youtube-dl...
I wasn't going to bother suggesting this just for my old netbook, but I just noticed that all 32 bit iOS devices are stuck with Kodi 18. This includes iPads with retina screens.
If the goal is to simplify development (how much development is planned?) then maybe this repo can be forked into a Python 2 source repo that just runs automated updates of youtube-dl and nothing else? That'd preserve a strong use case of repurposing old iPads -- tablets that seriously can't even browse the web anymore because of outdated browsers and certificates. I think the convenience of sending videos to iPads would be a good way to keep them from becoming planned e-waste.
That wouldn't complicate any future development, would it?
If the goal is to simplify development (how much development is planned?) then maybe this repo can be forked into a Python 2 source repo
That's the point. IMHO, development should keep up with the latest changes upstream (i.e. at Kodi) since that ensures a smooth experience for the vast majority of users. There isn't even a need for an official fork as long as only a handful of users are affected. For this specific plugin, I suggest the following:
- Clone this repo into the Kodi
addonsdirectory (instead of installing it via zip) - Checkout a
custombranch - Revert the commits you don't want (e.g. from this PR)
This way you can always merge the latest changes from master into custom, while retaining compatibility with your legacy systems. I used the same approach to fix things locally before, thankfully, #119 came along.
Give it a try!
PS: I commented here because I was just about to create the same PR for this issue. Please, let's merge this 😇
You might be right about that. If it really helps someone who wants to contribute then, yeah...
I do feel for all the 32 bit iPads though — excellent screens :-) and not a lot (?) of other use-cases. The problem isn't getting a modified addon on there, but to get the weekly updates of YouTube-dl. These updates would then revert your changes. Edit: apparently I didn't read. Yes, maybe your method would work, with the modification that you can't really do a lot of file operations on iPads, so I guess a modified repo.zip is necessary for that use case.
Disclosure: I'm not using anything older than Kodi 21.2 nowadays, but experimented last year with some iOS side-loading just to see what could be squeezed out of an old iPad.
Yes, maybe your method would work, with the modification that you can't really do a lot of file operations on iPads
True, but I'd argue that's a very isolated use case 🤓 But then again, you could still have your fork locally (on a non-iOS/iPadOS device), zip things up and deploy it to the iPad. For me this is a common approach to maintain special interests and it works well.
True, but I'd argue that's a very isolated use case 🤓
Yeah maybe. I wanted to help save not just my iPad 3 (actually I don't even own an iPad 🙂) but everyone's, and that would've required hassle-free OTA updates.
A project for another time perhaps.