first-contributions icon indicating copy to clipboard operation
first-contributions copied to clipboard

Removing space between name and profile link in Contributors.md

Open ThureinS opened this issue 1 year ago β€’ 2 comments

The Contributors.md file contains many lines that is not formatted correctly.

🐞 Problem Some lines of the Contributors.md contains space between the name and profile link. Example format is [name](link) which will appear as name while the error lines are [name] (link). Thus, the name does not appear as it is intended.

🎯 Goal Remove space between name and profile link so the names will appear as it is intended thus most of the name are formatted equally.

πŸ’‘ Possible solutions Remove space between name and github profile link

πŸ“‹ Steps to solve the problem

  • Check the Contributors.md and edit the wrong lines.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. πŸŽ‰

ThureinS avatar May 21 '24 08:05 ThureinS

Updated the list till line 1427. Please confirm.

ThunderShadows avatar May 22 '24 16:05 ThunderShadows

I think pull requests will be handled by maintainers. I am not currently working on this issue because my first pull request is not yet merged so I am waiting for that.

ThureinS avatar May 23 '24 04:05 ThureinS

i dont mind working on this if it still openedπŸ₯²

Asin-Junior-Honore avatar May 29 '24 15:05 Asin-Junior-Honore

It is still open. The file still contains some unformatted names

ThureinS avatar May 30 '24 03:05 ThureinS

copy paste from ChatGPT. Let the maintainer do it

ByteJoseph avatar May 30 '24 05:05 ByteJoseph

So should I go ahead and make the requested changes, or should I wait for it to be assigned to me?πŸ₯²

Asin-Junior-Honore avatar May 30 '24 08:05 Asin-Junior-Honore

So should I go ahead and make the requested changes, or should I wait for it to be assigned to me?πŸ₯²

wait to be assigned

ByteJoseph avatar Jun 01 '24 03:06 ByteJoseph

Hello i would like to work on this issue, can it be assigned to me?

diamond-nicholas avatar Jun 06 '24 10:06 diamond-nicholas

I am Dolly Chaudhary.I am looking forward to work on this issue.Kindly assign it to me @ThureinS

dollychaudhary25 avatar Jun 16 '24 11:06 dollychaudhary25

This issue will be always happening I guess. I closed this issue because my pull request from the last month is still not merged so I think the maintainers are busy.

ThureinS avatar Jun 17 '24 10:06 ThureinS

The Contributors.md file contains many lines that is not formatted correctly.

🐞 Problem Some lines of the Contributors.md contains space between the name and profile link. Example format is [name](link) which will appear as name while the error lines are [name] (link). Thus, the name does not appear as it is intended.

🎯 Goal Remove space between name and profile link so the names will appear as it is intended thus most of the name are formatted equally.

πŸ’‘ Possible solutions Remove space between name and github profile link

πŸ“‹ Steps to solve the problem

  • Check the Contributors.md and edit the wrong lines.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. πŸŽ‰

Hi! Thanks for bringing this up.

The maintainer has already discussed the spacing issue and the importance of following the format.

Therefore, it's not advised to reformat the contribution docs, as it often leads to content being removed due to increased file size.

Please check the 3rd bullet in this issue for more details:

  1. Contributors.md doesn't matter

This is one point where I had multiple discussions with the community. Contributors list exists just as a file you can edit to work through the tutorial. How it looks or what you add there doesn't matter. We'll remove most entries in it from time to time because we don't want someone being left out because their text editor can't open a huge file.

  • https://github.com/firstcontributions/first-contributions/issues/35892.

Esh07 avatar Aug 20 '24 22:08 Esh07