first-contributions
first-contributions copied to clipboard
Added Vietnamese translation of (new) Github Desktop (GUI Tool tutorial)
Like the title said.
Some of the translated sentences are translated by Tran Ly Vu (that I got from README.md
)
Vietnamese translation of old Github Desktop will out soon..
Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:
- Contributors.md
- gui-tool-tutorials/translations/github-desktop-tutorial.vn.md
Thank you @FlopffyGrape for your contribution to the Vietnamese translation! Your contribution and help are greatly appreciated.
@tranlv, we would be grateful if you could take a moment to review the changes made by @FlopffyGrape. Your thoughts and input are highly valued and appreciated.
Thanks, Esh π
@Esh07 I dunno why my branch said that there are conflicts that must to be resolved. I wonder why did it notify me this and how to resolve the problem? Maybe this is the reason why my reviewer @tranlv haven't reviewed my changes and pushed to main branch since I have created this Pull Request for almost 1 week?
@Esh07 Hi, thanks for your contribution. I will try to review within this week
@Esh07 I dunno why my branch said that there are conflicts that must to be resolved. I wonder why did it notify me this and how to resolve the problem? Maybe this is the reason why my reviewer @tranlv haven't reviewed my changes and pushed to main branch since I have created this Pull Request for almost 1 week?
Donβt worry about the merge conflict. Merge conflicts are constantly happening with the Contributors.md
file as it rapidly changes.
Once your PR has been successfully reviewed and is ready to be merged, the maintainer will be able to resolve the merge conflict for you.
Hey @tranlv, thank you for taking the time to review the changes in this PR. Your feedback and contribution are greatly appreciated.
Cheers, Esh
@Esh07 It seems that I could not approve
where is the approve button?
where is the approve button?
Visit this link and then you can see button called "Review changes" and from there select "Approve" and write your message.
@Esh07 Approved
Thanks a lot! ππ
Umm.. when will my changes be merged to main branch?
Hey @Roshanjossey, this PR is ready to merge!
Cheers, Esh
Cmon.. It's a week... -.-
Hello, congratulations! You've successfully submitted a pull request. π
If you liked the tutorial, please star this repo by clicking the star button on the top right of this page.
Next steps
- Continue contributing: If you're looking for projects to contribute to, checkout our
webapp.
- Join our Slack group: We have a community to help/support contributors.
Join slack group.
- Share on social media: You can share this content to help more people.
We'd love to hear your thoughts about this project. Let us know how we can improve by commenting or opening an issue here.
I have a question. Although I opened this PR and my changes have been merged to main branch, but why haven't I received the "Pull Shark" achievement? I know this is seem a stupid question, but plz explain if you know. Thanks
Not an expert on this but it could be your settings
More info in https://github.com/orgs/community/discussions/37577