first-contributions icon indicating copy to clipboard operation
first-contributions copied to clipboard

Added Vietnamese translation of (new) Github Desktop (GUI Tool tutorial)

Open hien-ngo29 opened this issue 1 year ago β€’ 13 comments

Like the title said. Some of the translated sentences are translated by Tran Ly Vu (that I got from README.md)

Vietnamese translation of old Github Desktop will out soon..

hien-ngo29 avatar Aug 03 '23 09:08 hien-ngo29

Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:

  • Contributors.md
  • gui-tool-tutorials/translations/github-desktop-tutorial.vn.md

github-actions[bot] avatar Aug 03 '23 09:08 github-actions[bot]

Thank you @FlopffyGrape for your contribution to the Vietnamese translation! Your contribution and help are greatly appreciated.

@tranlv, we would be grateful if you could take a moment to review the changes made by @FlopffyGrape. Your thoughts and input are highly valued and appreciated.

Thanks, Esh 😊

Esh07 avatar Aug 03 '23 17:08 Esh07

@Esh07 I dunno why my branch said that there are conflicts that must to be resolved. I wonder why did it notify me this and how to resolve the problem? Maybe this is the reason why my reviewer @tranlv haven't reviewed my changes and pushed to main branch since I have created this Pull Request for almost 1 week?

hien-ngo29 avatar Aug 08 '23 15:08 hien-ngo29

@Esh07 Hi, thanks for your contribution. I will try to review within this week

tranlv avatar Aug 09 '23 05:08 tranlv

@Esh07 I dunno why my branch said that there are conflicts that must to be resolved. I wonder why did it notify me this and how to resolve the problem? Maybe this is the reason why my reviewer @tranlv haven't reviewed my changes and pushed to main branch since I have created this Pull Request for almost 1 week?

Don’t worry about the merge conflict. Merge conflicts are constantly happening with the Contributors.md file as it rapidly changes.

Once your PR has been successfully reviewed and is ready to be merged, the maintainer will be able to resolve the merge conflict for you.

Hey @tranlv, thank you for taking the time to review the changes in this PR. Your feedback and contribution are greatly appreciated.

Cheers, Esh

Esh07 avatar Aug 21 '23 12:08 Esh07

@Esh07 It seems that I could not approve

tranlv avatar Sep 05 '23 03:09 tranlv

where is the approve button?

tranlv avatar Sep 05 '23 15:09 tranlv

where is the approve button?

Visit this link and then you can see button called "Review changes" and from there select "Approve" and write your message.

Esh07 avatar Sep 06 '23 22:09 Esh07

@Esh07 Approved

tranlv avatar Sep 10 '23 04:09 tranlv

Thanks a lot! πŸ˜ƒπŸ˜ƒ

hien-ngo29 avatar Sep 10 '23 05:09 hien-ngo29

Umm.. when will my changes be merged to main branch?

hien-ngo29 avatar Sep 12 '23 13:09 hien-ngo29

Hey @Roshanjossey, this PR is ready to merge!

Cheers, Esh

Esh07 avatar Sep 12 '23 17:09 Esh07

Cmon.. It's a week... -.-

hien-ngo29 avatar Sep 22 '23 08:09 hien-ngo29

Hello, congratulations! You've successfully submitted a pull request. πŸŽ‰

If you liked the tutorial, please star this repo by clicking the star button on the top right of this page. star screenshot

Next steps

We'd love to hear your thoughts about this project. Let us know how we can improve by commenting or opening an issue here.

celebration gif

Roshanjossey avatar Dec 27 '23 17:12 Roshanjossey

I have a question. Although I opened this PR and my changes have been merged to main branch, but why haven't I received the "Pull Shark" achievement? I know this is seem a stupid question, but plz explain if you know. Thanks

hien-ngo29 avatar Dec 29 '23 14:12 hien-ngo29

Not an expert on this but it could be your settings image

More info in https://github.com/orgs/community/discussions/37577

Roshanjossey avatar Dec 29 '23 15:12 Roshanjossey