first-contributions icon indicating copy to clipboard operation
first-contributions copied to clipboard

Inconsistency in the images used in readme files of different langauges other than English

Open Rhitabrat opened this issue 3 years ago • 6 comments

The images used in the readme files of languages other than English are inconsitent.

🐞 Problem

  • The first image (fork.png) has shadow while the other two images (clone.png and copy-to-clipboard.png) do not have shadows.
  • The source urls for these images are not the same as the ones used in "README.md".

🎯 Goal

  • Consistency in images used throughout the repo

💡 Possible solutions

  • Use the same img src's used in "README.md" in all the readme files of other languages.
  • Or, upload other images with the same shadow.

Though not a major problem, it helps to develop the objective of consistency for novice developers.

Rhitabrat avatar Oct 22 '20 13:10 Rhitabrat

I am a newbie. I understood the solution to this issue. But don't know how to proceed from here.

👇 these are my questions

  • In which branch I should commit?
  • how these issues work?
  • What is assigned in the top right corner?

dilipkn007 avatar Nov 30 '20 04:11 dilipkn007

As a part of https://github.com/firstcontributions/first-contributions/issues/34612, most of the images were updated. So, this issue might be solved. @Rhitabrat, could you confirm?

@dilipkn007, as your questions are general and would apply to all issues, I'll answer here.

In which branch I should commit?

Create a new branch yourself when working on your changes. git checkout -b branch-name

how these issues work?

Could you rephrase the question or be more specific? What do you understand so far. What don't you understand?

What is assigned in the top right corner?

Issues can be assigned to people who work on it or who'll take ownership of the discussion .

Roshanjossey avatar Nov 30 '20 10:11 Roshanjossey

Yes, src for all the images on readme files are updated with new repo. However, @dilipkn007 may change those images because all those images do not have the same shadowing and they are of low quality.

Rhitabrat avatar Nov 30 '20 10:11 Rhitabrat

@Rhitabrat, could you be more specific of which images you're referring to? I'm assuming that it's not all of them.

Roshanjossey avatar Nov 30 '20 11:11 Roshanjossey

@Roshanjossey Images with shadows on four sides:

  1. submit-pull-request.png poor quality
  2. compare-and-pull.png poor quality

Images with shadows on three sides:

  1. fork.png
  2. copy-to-clipboard.png
  3. clone.png

Image with no shadow

  1. git-status.png

Rhitabrat avatar Nov 30 '20 11:11 Rhitabrat

Images with shadows on three sides Image with no shadow

This is not a problem for the images mentioned. The idea of shadows is for the assets to stand out from the background. For the images with shadows on three sides, I took inspiration from material design. I think it looks good and does stand out from the background.

Roshanjossey avatar Nov 30 '20 12:11 Roshanjossey

assign this task to me

salvador001 avatar Sep 26 '22 18:09 salvador001

Hello Sir , Can You Assign This Issue to Me?

KiranPatil30 avatar Oct 08 '22 18:10 KiranPatil30

This issue was already resolved.

@KiranPatil30, you don't have to call anybody 'Sir' here. use their names or usernames.

Roshanjossey avatar Oct 08 '22 23:10 Roshanjossey

@KiranPatil30, I don't see your PR https://github.com/firstcontributions/first-contributions/pulls?q=is%3Apr+author%3AKiranPatil30. Can you share a link?

Roshanjossey avatar Oct 09 '22 08:10 Roshanjossey