first-contributions icon indicating copy to clipboard operation
first-contributions copied to clipboard

Syria language

Open Ghaith-Shammout opened this issue 4 weeks ago • 3 comments

Before submitting this pull request, check the changes to see it's only the changes you made intentionally If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier. Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

If you're doing something in the checklist below, put an x inside [ ] so that - [ ] becomes - [x]

  • [ ] I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • [ ] There are some things I'd like to improve in this tutorial. I have written them below.
  • [ ] There were steps where I had errors while following this tutorial. I have written them below.

Ghaith-Shammout avatar Dec 08 '25 08:12 Ghaith-Shammout

Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:

  • Contributors.md
  • README.md
  • docs/translations/README.apc.md

github-actions[bot] avatar Dec 08 '25 08:12 github-actions[bot]

Hi @rammba and thanks for your help on this PR. I updated the branch based on your feedback.

When it comes to the language, it should be Arabic with Syria dialect. I missed to type Arabic because I was very exited to contribute to this repo.

Kindly, let me know if there anything that need further attention

Ghaith-Shammout avatar Dec 09 '25 08:12 Ghaith-Shammout

Not at all, I like getting feedback 😊 What if I want this contribution to be in Levantine Arabic, what should I call the README file, what additional step do I need to take?

Ghaith-Shammout avatar Dec 10 '25 07:12 Ghaith-Shammout

Hello @Ghaith-Shammout, thanks for the interest in the proper naming of the file. I'm not familiar with variations of Arabic languages at all, but, in theory, it's possible to add both Syrian Arabic and Levantine Arabic, if they are not the same. As mentioned in #105711, we want to name files with proper language code based on ISO 639 list. So, if you want to use Levantine, use apc code, or ar-sy for Syrian Arabic.

rammba avatar Dec 10 '25 15:12 rammba

Hi @Ghaith-Shammout do you understand the content in https://github.com/firstcontributions/first-contributions/blob/main/docs/translations/README.ar.md ?

Roshanjossey avatar Dec 10 '25 20:12 Roshanjossey

Yes, I do understand the content in that README file @Roshanjossey. I just want to contribute to this repo by adding the Levantine Arabic.

Ghaith-Shammout avatar Dec 17 '25 20:12 Ghaith-Shammout

Hello @Roshanjossey, you can merge new language, Levantine Arabic 🚀

rammba avatar Dec 17 '25 20:12 rammba

Thank you for yours support 🤍

Ghaith-Shammout avatar Dec 17 '25 20:12 Ghaith-Shammout

I asked my Syrian friends too. They can also understand https://github.com/firstcontributions/first-contributions/blob/main/docs/translations/README.ar.md. In this case, I think it's best not to add this translation.

Roshanjossey avatar Dec 22 '25 22:12 Roshanjossey

Hello @Roshanjossey, even though they understand, maybe this language has varieties with the original Arabic. I'm not familiar with Arabic, but Balkan languages (Serbian, Croatian, Bosnian, Montenegrin) are also a bit similar, and we have all of them listed. There are differences of course, but I think people can grasp the gist of the content in these languages.

rammba avatar Dec 22 '25 23:12 rammba