firstcontributions
Improve Traditional Chinese translation in README.zh-tw.md
Summary
This pull request improves the Traditional Chinese translation in README.zh-tw.md.
Changes
- Refined wording to make the translation more natural for Taiwanese readers
- Unified technical terminology such as “Git”, “branch”, “commit”, and “push”
- Improved punctuation, spacing, and overall readability
- Corrected minor typos and awkward expressions
Notes
Although this repository is mainly for practicing first-time contributions,
this PR aims to genuinely improve the documentation so that future contributors using the Traditional Chinese version can follow it more clearly.
Hello @ruryu. Thank you for making this PR! ✨ If possible, we can discuss some of the modifications in the proposed commit. I have tried my best to explain my thoughts in detail. Please feel free to let me know if you have any questions or suggestions.
Hello @Roshanjossey, Sorry for the late review, I was out of town last* weekend. There are some proposed commit needed discussion, let me know what do you think about them!
Thank both of you in advance! 🎉
Thank you for such a detailed review @Sharl0tteIsTaken. I really appreciate the time, effort and attention you put into it.
Don't worry about taking time. There's no pressure from my side.
For other issues or pull requests that needs my input, please tag me. If you think a change doesn't make sense, you can close it yourself.
Hello @Roshanjossey, thank you for your reply and affirmation. 🙏
This PR does propose some changes needed your input:
- Line 7:
The translation should use either spoken (colloquial) or written language (colloquial is used prior to this proposed commit).I think we can keep things as they are unless there's a reason to change them. - Line 26:
The translation of you (你/妳)The Chinese wordyouhas gender distinctions, this PR is proposing changes to only use你, I think it's best to stay as is, reasonings described here. - Line 167:
Project supporter section is not present on the English README, but present in the Chinese translation (both Simplified and Traditional)Is this supportive relationship still ongoing?
What are your thoughts on these? Thank you in advance! ✨
Hello @Roshanjossey, thank you for your reply and affirmation. 🙏
This PR does propose some changes needed your input:
- Line 7:
The translation should use either spoken (colloquial) or written language (colloquial is used prior to this proposed commit).I think we can keep things as they are unless there's a reason to change them.
Let's keep the current version. I think it's good to be a little informal.
- Line 26:
The translation of you (你/妳)The Chinese wordyouhas gender distinctions, this PR is proposing changes to only use你, I think it's best to stay as is, reasonings described here.
It's best to keep it gender neutral. Let's keep the current version.
- Line 167:
Project supporter section is not present on the English README, but present in the Chinese translation (both Simplified and Traditional)Is this supportive relationship still ongoing?
No, this sponsorship ended. We don't have to add it now.
Hello @Roshanjossey, thanks for the response. 🙏
I will make changes accordingly, the sponsorship section will be removed, unmentioned reviews will be changed after further discussion with @ruryu.