Fix compiler warnings

[aleflm]

Includes two commits:

• Update lib immer to a more recent version (v0.8.1 5875f7739a6c642ad58cbedadb509c86d4212). This fixes a lot of random warnings we have in lib immer.
• Fixed warnings in Linux / Clang.
• Fixed warnings in Win cross-compile.
• no-gui build only.

Summary by CodeRabbit

• Refactor
  • Improved code readability and performance in various library components through restructuring and optimizations.
  • Enhanced error handling and memory management across several modules.
• New Features
  • Introduced new member functions and improvements in mutable versions of map, set, and table classes.
• Bug Fixes
  • Adjusted file path handling logic to correctly handle absolute paths.
• Chores
  • Updated configuration with macros for C++17 features, exception handling, debugging, and compiler-specific optimizations.
• Documentation
  • Added necessary include directives across multiple files for better code management and clarity.

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The updates across various components primarily focus on improving code readability, performance, and error handling. Key enhancements include the suppression of warnings, inclusion of necessary headers, redefinition of macros for modern C++ features, and better path handling. Notably, the immer library and secp256k1 module receive significant refinements, while changes in wallet functionality and protocol handling ensure more robust operations.

Changes

Files	Summary
src/compat/glibcxx_sanity.cpp	Suppressed unused result warning
src/immer/...	Enhanced readability, performance, and error handling; Added IMMER_NODISCARD to member functions
src/config.hpp	Added macros for C++17 features, debug-related macros, and compiler-specific optimizations
src/rpc/protocol.cpp, src/util.cpp	Improved path handling by checking if path is absolute
src/secp256k1/src/...	Simplified code and improved performance; Added necessary include directives
src/wallet/wallet.cpp	Updated file path and backup functionality using boost::filesystem

Poem

🌟 In the code garden, where changes bloom,
🐇 A rabbit hopped, dispelling gloom.
"With each line refined, and bugs entombed,
🚀 Our project's bound for the moon!"
So cheer, for the craft, and the hands that groom,
📈 For progress sings a joyful tune.
🌈 And in this digital cocoon, we zoom!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aleflm]

@coderabbitai review