firo icon indicating copy to clipboard operation
firo copied to clipboard

Group element hash generation restricts range unnecessarily

Open AaronFeickert opened this issue 3 years ago • 0 comments

The hash-to-group function GroupElement::generate performs a conditional negation that restricts the output range unnecessarily: https://github.com/firoorg/firo/blob/master/src/secp256k1/src/cpp/GroupElement.cpp#L383-L385

This function appears only to be used for generating public parameters, but should be documented as unsafe for future use.

AaronFeickert avatar Jan 07 '22 19:01 AaronFeickert