Oliver Stöneberg

Results 1147 comments of Oliver Stöneberg

Sorry for not testing the changes yet, but something else came up. > > We had the problem that when you create a PR from a branch in the same...

Okay, I gave it a spin. This prevents the workflows from running more than once on `main`. In our case that is fine and it might cause delays (in some...

We can make this work this by making the concurrency a unique ID for the non-PR case: ```yaml concurrency: group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.head_ref || github.sha }} cancel-in-progress:...

> We can make this work this by making the concurrency a unique ID for the non-PR case: In that case we might not even need the conditional value for...

> We can make this work this by making the concurrency a unique ID for the non-PR case: Oh no - that is all wrong (it's too warm). That is...

> This will have the same effect with the changes in this PR, under the condition that from a single branch, only one PR can be opened. ```sh echo "${{...

Will have another look later today. > It also works in the case where from branch `feature-X` you open two PRs (I can't think of a reason why someone would...

> It is possible only if the target branch is different: I can open a PR from `feature/A` to `main` and another PR from `feature/B` to `develop`. That is very...

Please rebase and drop the stray bad commit.