Oliver Stöneberg
Oliver Stöneberg
> I like the interface that we pass the istream to simplecpp. it makes the interface more strict. a const char* parameter can be a filename, code, configuration, etc. That...
> But developers sometimes mix up the parameters and with a `const char*` there is nothing that prevents that for instance the filename is passed by mistake to that parameter....
> a const char* parameter can be a filename, code, configuration, etc. You should check the documentation before you use it but point taken. Maybe we could use more descriptive...
> Maybe we could use more descriptive names like `Buffer` or `FromFile` suffixes. That would also make sense for the `TokenList::createTokens()` functions. I did that - please have a look.
I might also still need to add convenience stream versions to the interface. And we would need tests for that - I am not so sure anymore about adding essentially...
> I just don't like this. A istream parameter is better than 2 `const uint8_t*, int size` parameters imo. An istream is also more explicit than a string_view or a...
Thanks for your contribution. Please add a unit test to `test/testother.cpp`.
I went a bit overboard with the cleanups. I will pull out the unrelated changes into a separate PR. I also think I miss a testcase of the empty original...
The original filename is actually different in `TokenList` when using `-rp`.
I still want to re-phrase the messages. They feel clunky. Also the co-author is somehow not working.