firesim
firesim copied to clipboard
ci: remove more instances of stderr/stdout redirection
This does not actually affect CI performance but makes it materially harder to debug.
Related PRs / Issues
UI / API Impact
Verilog / AGFI Compatibility
Contributor Checklist
- [x] Is this PR's title suitable for inclusion in the changelog and have you added a
changelog:<topic>label? - [x] Did you add Scaladoc/docstring/doxygen to every public function/method?
- [x] Did you add at least one test demonstrating the PR?
- [x] Did you delete any extraneous prints/debugging code?
- [x] Did you state the UI / API impact?
- [x] Did you specify the Verilog / AGFI compatibility impact?
- [x] If applicable, did you regenerate and publicly share default AGFIs?
- [ ] If applicable, did you apply the
ci:fpga-deploylabel?
- [ ] If applicable, did you apply the
Please Backportlabel?
Reviewer Checklist (only modified by reviewer)
- [ ] Is the title suitable for inclusion in the changelog and does the PR have a
changelog:<topic>label? - [ ] Did you mark the proper release milestone?
- [ ] Did you check whether all relevant Contributor checkboxes have been checked?
I still don't see why https://github.com/firesim/firesim/runs/7753211481?check_suite_focus=true is failing. I mean, I see that one of the drivers is blowing up during infrasetup but I don't see where the driver compile is failing.
I still don't see why https://github.com/firesim/firesim/runs/7753211481?check_suite_focus=true is failing. I mean, I see that one of the drivers is blowing up during infrasetup but I don't see where the driver compile is failing.
Agreed. This seems suspicious.
It kinda smells like the switch code doesn't compile for some reason right?
@Mergifyio rebase
rebase
✅ Branch has been successfully rebased
@mergifyio rebase
rebase
✅ Branch has been successfully rebased
Is this ready to be merged @davidbiancolin?
I've held off because it does seem that for these jobs they do run slower. Also the boot log isn't directly useful, since it's mostly just the status updates from the manager. I'm just going to close this.