firesim icon indicating copy to clipboard operation
firesim copied to clipboard

ci: remove more instances of stderr/stdout redirection

Open davidbiancolin opened this issue 3 years ago • 7 comments

This does not actually affect CI performance but makes it materially harder to debug.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • [x] Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • [x] Did you add Scaladoc/docstring/doxygen to every public function/method?
  • [x] Did you add at least one test demonstrating the PR?
  • [x] Did you delete any extraneous prints/debugging code?
  • [x] Did you state the UI / API impact?
  • [x] Did you specify the Verilog / AGFI compatibility impact?
  • [x] If applicable, did you regenerate and publicly share default AGFIs?
  • [ ] If applicable, did you apply the ci:fpga-deploy label?
  • [ ] If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

  • [ ] Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • [ ] Did you mark the proper release milestone?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?

davidbiancolin avatar Aug 09 '22 15:08 davidbiancolin

I still don't see why https://github.com/firesim/firesim/runs/7753211481?check_suite_focus=true is failing. I mean, I see that one of the drivers is blowing up during infrasetup but I don't see where the driver compile is failing.

timsnyder-siv avatar Aug 09 '22 22:08 timsnyder-siv

I still don't see why https://github.com/firesim/firesim/runs/7753211481?check_suite_focus=true is failing. I mean, I see that one of the drivers is blowing up during infrasetup but I don't see where the driver compile is failing.

Agreed. This seems suspicious.

abejgonzalez avatar Aug 10 '22 04:08 abejgonzalez

It kinda smells like the switch code doesn't compile for some reason right?

davidbiancolin avatar Aug 10 '22 06:08 davidbiancolin

@Mergifyio rebase

timsnyder-siv avatar Aug 10 '22 23:08 timsnyder-siv

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 10 '22 23:08 mergify[bot]

@mergifyio rebase

davidbiancolin avatar Sep 21 '22 00:09 davidbiancolin

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Sep 21 '22 00:09 mergify[bot]

Is this ready to be merged @davidbiancolin?

abejgonzalez avatar Sep 26 '22 20:09 abejgonzalez

I've held off because it does seem that for these jobs they do run slower. Also the boot log isn't directly useful, since it's mostly just the status updates from the manager. I'm just going to close this.

davidbiancolin avatar Sep 28 '22 17:09 davidbiancolin