nft-art-generator icon indicating copy to clipboard operation
nft-art-generator copied to clipboard

Some images generated are repeated

Open nicolasvegaabril opened this issue 3 years ago • 4 comments

The code isn't checking for repeated variations correctly

nicolasvegaabril avatar Jan 20 '22 01:01 nicolasvegaabril

I've created a PR with a fix

nicolasvegaabril avatar Jan 20 '22 01:01 nicolasvegaabril

Would you consider writing a test for this to demonstrate the PR fix?

tylerjharden avatar Jan 25 '22 21:01 tylerjharden

I've created a PR with uniqueness checking at the end.

shpun817 avatar Feb 05 '22 09:02 shpun817

In regards to this issue lines 75-80 should be changed to

if (takenFaces[face]) {
    createImage(); 
  } else {
    const name = getRandomName();
    console.log(name);
    takenFaces[face] = face;

to not use face[takenFaces] = face. Looks like this error is coming from incorrectly using an object instance to index an array...

lbxa avatar May 03 '22 06:05 lbxa