222-responsive-icon-nav-css

222-responsive-icon-nav-css copied to clipboard

no theme

1

when I run the code there is no icon on themify and clicking it did nothing, I added: ` let fh = localStorage.setItem('theme', 'dark') ` in theme.js on line 5...

spydmobile

Navbar overflow fix, scroll track theme match

1

Navbar y-axis overflow on large screens, and x-axis overflow on hover hidden.

rushyab

williamz6

JoaoLourencao

well, that was giving a ugly effect, the scrollbar was scroll able.

tewarig

When hovering, the link is displayed out of the box and disappears when the animation has not yet finished. I propose to correct the overflow on the x axis.

Asalraalaikum

Minor update to style.css

1

Removed excess 10rem from the media queries

holtning

https://github.com/fireship-io/222-responsive-icon-nav-css/blob/932ba4732e12855ba87521f06fccf6b4bc5fb243/public/style.css#L172 should this be 1 or 2rem? This is the screenshot of 11rem  vs 1rem below ![Screen Shot 2020-04-20 at 12 30...

holtning

Fix using class property twice

1

You're using the same properties twice,,, Just follow the best practice...

dhonx

alohe