fireproof icon indicating copy to clipboard operation
fireproof copied to clipboard

cleanup package.json

Open jchris opened this issue 1 year ago • 3 comments

Currently we list React etc which we dont need / use

https://github.com/fireproof-storage/fireproof/blob/ccacf52642b74363762f226895cf70496cb7f8dd/package-fireproof-core.json#L51

It'd make auditing this a lot easier for 3rd parties.

jchris avatar Oct 14 '24 15:10 jchris

this is still here: https://github.com/fireproof-storage/fireproof/blob/bf7a78b2a6d6def3ede2a19fd64d18aa09ca48a2/package.json#L96

jchris avatar Jan 03 '25 01:01 jchris

is this still needed in core? https://github.com/fireproof-storage/fireproof/blob/bf7a78b2a6d6def3ede2a19fd64d18aa09ca48a2/package-fireproof-core.json#L40

jchris avatar Jan 03 '25 01:01 jchris

I suggest removing the above references and switching this to the raw version number instead of referencing the root package.json -- unless there is a reason to have the peer-dependency number surfaced on the core package.json as a peer... not sure we need that

Code: https://github.com/fireproof-storage/fireproof/blob/bf7a78b2a6d6def3ede2a19fd64d18aa09ca48a2/package-use-fireproof.json#L31

jchris avatar Jan 03 '25 01:01 jchris