fds icon indicating copy to clipboard operation
fds copied to clipboard

3D slices not working with GEOM

Open rmcdermo opened this issue 1 year ago • 4 comments

Try this test case:

sphere_helium_1mesh.fds.txt

As is, the slice shows up as pictured below, that is, a pane normal to the x direction. Note that the arrows do not work in this case to show additional slices, moving in x, or changing directions to y or z.

Screenshot 2023-05-09 at 10 42 49 AM

In the input file, there is a nominally equivalent OBST line. Comment the GEOM line and uncomment the OBST and things look fine. So, this seems to be an issue of writing the 3D slices form FDS. This is using SMV-6.8.0-89-g5e0e76e0f-master.

Screenshot 2023-05-09 at 10 41 36 AM

rmcdermo avatar May 09 '23 14:05 rmcdermo

geometry slices work by outputting the data and also vertices and faces corresponding to that data. in order to implement a 3D geometry slice file the same way as for structured slice files we would need to output vertices and faces for each XY slice, XZ slice and YZ slice and these vertices would need to correspond ie be output in the same order as the data is output. if you want to make these changes to do this in FDS and I can make the corresponding changes in smokeview. (or let me know if you think all of this geometry is being output now - I would need a way of identifying which geometry plane is which) in the mean time I will turn off 3d geometry slices in smokeview to avoid confusion

gforney avatar May 15 '23 13:05 gforney

At the moment I am thinking in terms of getting structured 3D slices to work with GEOM. GEOM does not support split cells, so we can just put the cutcell value in the Cartesian cell and then do slices as normal.

rmcdermo avatar May 15 '23 13:05 rmcdermo

on the smokeview side, smokeview shouldn't care if the the 3D slice file is in the old structured format - should work

gforney avatar May 15 '23 14:05 gforney

Quick update on this. Looks like if we just leave the default SLICETYPE='STRUCTURED' for GEOM then the 3D slices work as expected. I suggest we make this change. It does not preclude us from adding SLICETYPE='INCLUDE_GEOM' if we want that for a specific case.

At about line 14290 in read.f90 I suggest we do:

            !IF(TRIM(SLICETYPE)=='STRUCTURED') SLICETYPE = 'INCLUDE_GEOM'

Then the case works as shown below with a temperature slice.

Screenshot 2023-05-25 at 4 32 59 PM

rmcdermo avatar May 25 '23 20:05 rmcdermo