firegento-magesetup2 icon indicating copy to clipboard operation
firegento-magesetup2 copied to clipboard

Published 20 hours ago • verified publisher icon firegento

[FEATURE] display attribute value of child product in cart

Open rommelfreddy opened this issue 2 years ago • 3 comments

Please make sure these boxes are checked before submitting your PR - thank you!

  • [x] Pull request is based against develop branch
  • [x] README.md reflects changes (if applicable)
  • [x] New files contain a license header

Issue

none

Proposed changes

this PR prints the child-attribute value in the cart instead of the configurable attribute value. This makes more sense, cause the admin would change the value in the child below. E.g. the SKU.

rommelfreddy avatar Oct 11 '22 16:10 rommelfreddy

Thanks for your contribution, @rommelfreddy! Could you check my comments and the failing pipeline?

I think the change makes sense, but I would love to get a second opinion from e.g. @frostblogNet :)

sprankhub avatar Oct 11 '22 19:10 sprankhub

@rommelfreddy thanks for the contribution. It would be nice if you could change the line metioned by @sprankhub. Sorry for the late response.

frostblogNet avatar Oct 25 '22 08:10 frostblogNet

@roman204, if you want to push this forward, feel free to send a new PR with the changes fixed. Since I don't need this at the moment and my time is very limited, I cannot just work on this.

sprankhub avatar Dec 10 '23 20:12 sprankhub