FireGento_FastSimpleImport2 icon indicating copy to clipboard operation
FireGento_FastSimpleImport2 copied to clipboard

Published 20 hours ago • verified publisher icon firegento

PHP 8.1 - Fix optional parameter error

Open VincentMarmiesse opened this issue 2 years ago • 5 comments

With PHP 8.1, fix the following error

Deprecated Functionality: Optional parameter $delimiter declared before required parameter $string is implicitly treated as a required parameter in /var/www/html/vendor/firegento/fastsimpleimport/Model/Import/Category.php on line 106

That's because $delimiter can't be optional if the following parameter $string is not.

VincentMarmiesse avatar May 03 '22 15:05 VincentMarmiesse

Thanks a lot, @VincentMarmiesse! This has actually already been tackled in https://github.com/firegento/FireGento_FastSimpleImport2/pull/121, which merges the changes into the bigger refactoring #120. So I tend to wait for the merge there. Do you agree, @avstudnitz?

sprankhub avatar May 03 '22 19:05 sprankhub

Hi @sprankhub ! Thanks for your answer, do you have any ETA on this?

VincentMarmiesse avatar May 10 '22 09:05 VincentMarmiesse

That pretty much depends on @avstudnitz. I think it is his turn :)

sprankhub avatar May 11 '22 07:05 sprankhub

Is there any news on when this will be released?

iwanvanzijderveld avatar Jun 29 '22 12:06 iwanvanzijderveld

@avstudnitz, could you give an update here? You invested so much time already, let us finish it together! Happy to review / help with it...

sprankhub avatar Jun 29 '22 18:06 sprankhub

Any updates here?

linshin avatar Aug 31 '22 12:08 linshin

Sorry, somehow I missed this comversation. I updated the PR and, yes, that issue is tackled in the 2.0 refactoring as well.

avstudnitz avatar Sep 30 '22 10:09 avstudnitz