FireGento_FastSimpleImport2 icon indicating copy to clipboard operation
FireGento_FastSimpleImport2 copied to clipboard

Published 20 hours ago • verified publisher icon firegento

Category Import fixes

Open rbrown opened this issue 2 years ago • 1 comments

This has the compatibility fixes I commented on, sets a default category_path_seperator "/", and reverses the parameters for explodeEscaped because having the first parameter optional is deprecated.

rbrown avatar Apr 25 '22 15:04 rbrown

@avstudnitz, do you think we can merge this?

sprankhub avatar May 03 '22 19:05 sprankhub

@rbrown, would you mind updating your PR and sending it to the current develop branch?

sprankhub avatar Oct 21 '22 12:10 sprankhub

Hi @sprankhub I'm not sure I've done this right now. There should be three commits, 1 to add a default category separator, with this I didn't need to reorder the method parameters, 2. Use the right DateTime class and 3. A fix for importing boolean attributes.

rbrown avatar Oct 21 '22 13:10 rbrown

Thanks a lot, @rbrown! I hope my comments make sense to you :)

sprankhub avatar Oct 21 '22 20:10 sprankhub

Thanks, @rbrown!

sprankhub avatar Oct 24 '22 13:10 sprankhub