FireGento_ExtendedImport2 icon indicating copy to clipboard operation
FireGento_ExtendedImport2 copied to clipboard

[Featrure] Support generating URL keys for same-name products

Open amenk opened this issue 7 years ago • 4 comments

Problem:

If you import two products with the same name, such as "T-Shirt" and one is "L", one is "M" - you have to specify the URL key manually. If would be nice to add a -SKU or something like that to the URL key.

References:

https://magento.stackexchange.com/questions/213036/url-was-already-generated-for-an-item-with-sku-error https://github.com/magento/magento2/issues/1471#issuecomment-381086616

amenk avatar Apr 13 '18 09:04 amenk

Should we fix that here?

amenk avatar Aug 17 '18 14:08 amenk

anybody ? Don't even know how to fix it :-(

amenk avatar Oct 04 '18 14:10 amenk

Found out it's already fixed at HoNl's module: https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ProductUrlKey.php

"Paul Hachmang [14:21 Uhr] We have a few things to handle duplicate URL keys: RowModifier to just append -1, -2, -3 to the URL https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ProductUrlKey.php (bearbeitet)"

"And two, for the creation of configurable products we have a completely custom URL builder that allows to to program exactly how the configurable/simple URL keys should work: https://github.com/ho-nl/magento2-Ho_Import/blob/master/src/RowModifier/ConfigurableBuilder.php"

Still the question @avstudnitz if this would be in scope of ExtendedImport2 or if we should create a totally seperate module?

amenk avatar Oct 10 '18 12:10 amenk

Yes, I think it would be good in this module. Thanks!

avstudnitz avatar Oct 11 '18 07:10 avstudnitz