profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Provide a "summary" view with top hotspots

Open julienw opened this issue 7 years ago • 4 comments

This view comes from the hotspot tool: top hotspots

┆Issue is synchronized with this Jira Task

julienw avatar Apr 25 '18 22:04 julienw

I'm not sure this is useful with what we already have. But tell me what you think @mstange @gregtatum @zoepage .

julienw avatar Apr 25 '18 22:04 julienw

@julienw would this similar to heaviest stack trace? https://help.apple.com/instruments/mac/current/#/devd53abb62

digitarald avatar Apr 25 '19 05:04 digitarald

I'm not sure what "heaviest stack trace" means.

I think this is a subset of https://github.com/firefox-devtools/profiler/issues/15, especially the first point of what Mike Conley described there.

I tried to implement this in https://github.com/firefox-devtools/profiler/pull/1538, except in this experiment I used the self time instead of the inclusive time to sort functions, but we want the inclusive time here.

The hotspot above keeps only a part of the list, kind of what I did in https://github.com/firefox-devtools/profiler/pull/1534 (360 view, aka summary view).

julienw avatar Apr 25 '19 12:04 julienw

I continued some discussion in #15 to narrow down the initial feature request.

digitarald avatar Apr 26 '19 04:04 digitarald