profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Selected and expanded node paths are not transformed when popping a transform

Open julienw opened this issue 7 years ago • 1 comments

Currently we don't transform selected and expanded node paths back when popping a transform.

I don't think this would be easy to "compute" all the expanded paths in that case, so I think there are 2 possible paths here:

  1. remember what the state was before adding the transform.
  2. only consider the selected path and expand the tree up to this selected path

┆Issue is synchronized with this Jira Task

julienw avatar Mar 22 '18 10:03 julienw

I'm taking off the bug label, as it was the intended behavior when I implemented it. Pushing and popping a transform will potentially result in a different set of call node paths, as they have different meanings. Plus implementing the reverse of the filters sounds like a hard problem.

I think remembering the state before adding the transform would be reasonable though.

gregtatum avatar Mar 26 '18 16:03 gregtatum