profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Make profile types stricter

Open gregtatum opened this issue 7 years ago • 0 comments

We should use exact objects and (if possible) covariant (read-only) properties.

e.g. turn this:

export type StackTable = {
  frame: IndexIntoFrameTable[],
  prefix: Array<IndexIntoStackTable | null>,
  length: number,
};

into this:

export type StackTable = {|
  +frame: IndexIntoFrameTable[],
  +prefix: Array<IndexIntoStackTable | null>,
  +length: number,
|};

┆Issue is synchronized with this Jira Task

gregtatum avatar Jan 30 '18 18:01 gregtatum