profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Test coverage for src/components/header

Open gregtatum opened this issue 7 years ago • 2 comments

In attempting to uncover our worst offenders for code coverage, the header component stands out.

  • [ ] TimeSelectionScrubber (53 lines uncovered)
  • [ ] IntervalMarkerOverview (47 lines uncovered)
  • [ ] ProfileThreadHeaderContextMenu (26 lines uncovered)
  • [ ] SelectionScrubberOverlay (26 lines uncovered)
  • [ ] ProfileThreadHeaderBar (25 lines uncovered)
  • [ ] ThreadStackGraph (14 lines uncovered)
  • [ ] OverflowEdgeIndicator (8 lines uncovered)
  • [ ] ProfileThreadJankOverview (6 lines uncovered)
  • [x] ProfileViewerHeader (3 lines uncovered)
  • [x] TimeRuler (2 lines uncovered)
  • [x] EmptyThreadIndicator (0 lines uncovered)
  • [x] ProfileThreadTracingMarkerOverview (0 lines uncovered)

┆Issue is synchronized with this Jira Task

gregtatum avatar Jan 24 '18 20:01 gregtatum

The src/components/header path no longer exists.

These 2 classes have been moved:

  • https://app.codecov.io/gh/firefox-devtools/profiler/blob/main/src%2Fcomponents%2Fshared%2Fthread%2FStackGraph.js
  • https://app.codecov.io/gh/firefox-devtools/profiler/blob/main/src%2Fcomponents%2Ftimeline%2FOverflowEdgeIndicator.js

patrykgruszka avatar Apr 27 '24 20:04 patrykgruszka

I believe the "header" directory moved to "timeline" indeed. For example I believe the two Selection files were merged to https://app.codecov.io/gh/firefox-devtools/profiler/blob/main/src%2Fcomponents%2Ftimeline%2FSelection.js (still needs some coverage)

Other components are missing coverage too, see https://app.codecov.io/gh/firefox-devtools/profiler/tree/main/src%2Fcomponents%2Ftimeline (esp GlobalTrack and LocalTrack, Ruler) due to recent changes that landed without tests.

julienw avatar Apr 29 '24 07:04 julienw