profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Make it possible to share a profile even before symbolication

Open julienw opened this issue 7 years ago • 9 comments

This is useful for users on slow machine.

2 possibilities:

  • directly share through the add-on, opening a simple page, so that the slow machine doesn't have to load the full react app
  • as a stop-gap measure we could allow the "share" button appear after clicking several times on its normal location.

(requested by @fqueze)

┆Issue is synchronized with this Jira Task

julienw avatar Jan 12 '18 16:01 julienw

Per #1325, the easiest way forward would be allowing cancellation of the symbolication, which in turn will enable the share button.

digitarald avatar Oct 03 '18 04:10 digitarald

+1 in adding a button to cancel the symbolication. Do we also need to adjust the message Symbolicating call stacks... and make it more human understandable as users might not understand what this is / why it is helpful?

zoepage avatar Oct 04 '18 06:10 zoepage

Make sense, especially when dogfooding users on the internet see this. We can keep the technical information in an alt tooltip (and maybe a learn more link with troubleshooting in the doc? we should do more of that for interesting parts of the UI that benefit from hints).

Friday vote time …

1️⃣ Processing Profile … 2️⃣ Loading profile information … 3️⃣ Reticulating splines … 4️⃣ Enhancing!

digitarald avatar Oct 04 '18 23:10 digitarald

3️⃣ Reticulating splines … 4️⃣ Enhancing!

Not sure if these 2 are purely a joke or semi-serious, but IMO replacing a message that's opaque to most users and meaningful to a few with a message that's opaque to everybody wouldn't be an improvement.

I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.

fqueze avatar Oct 05 '18 09:10 fqueze

Counter-proposition: 5️⃣ Fetching additional information… ?

julienw avatar Oct 08 '18 13:10 julienw

I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.

Good point.

Counter-proposition: 5️⃣ Fetching additional information… ?

I had that as an iteration of 2️⃣when I wrote it up, I like that too with the only downside is that it doesn't fully highlight the dependency on network bandwidth and server response time (compared to Loading). Maybe Downloading additional profile information …?

digitarald avatar Oct 10 '18 04:10 digitarald

Ah, this is funny :) for me the meaning for fetch is closer to a network-downloading than load :) I'd be OK with Downloading.

julienw avatar Oct 10 '18 10:10 julienw

I think sharing is possible before the end of symbolication with the new sharing flow. Is there more we want to do here, or should we just close this issue?

fqueze avatar Jul 30 '19 10:07 fqueze

I think the main issue has been fixed indeed. That said, do we still want to change the symbolication text?

julienw avatar Jul 30 '19 15:07 julienw