profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Call Tree filter input clear button isn't accessible

Open nchevobbe opened this issue 1 year ago • 2 comments

  • [ ] it doesn't have a label
  • [ ] it can't be focused with the keyboard

┆Issue is synchronized with this Jira Task

nchevobbe avatar Dec 02 '24 08:12 nchevobbe

Can you put a screenshot of the filter you're mentioning? The call tree filter I see can be focused by keyboard, at least for me on Linux. It's also enclosed in a label element but the tree is a bit weird indeed, I'm not sure it's properly applied.

julienw avatar Dec 02 '24 10:12 julienw

Can you put a screenshot of the filter you're mentioning? The call tree filter I see can be focused by keyboard, at least for me on Linux. It's also enclosed in a label element but the tree is a bit weird indeed, I'm not sure it's properly applied.

Erf, sorry, I forgot some words in the issue title. This is about the filter input clear button image

You could argue that when you focus the input text is selected so you can hit Delete to do the same thing, but I feel like having a visible button not being accessible with the keyboard isn't great. FWIW we have the same kind of clear button in the DevTools toolbox and the a11y team did file bug about those buttons not being accessible with the keyboard only

nchevobbe avatar Dec 02 '24 13:12 nchevobbe