profiler icon indicating copy to clipboard operation
profiler copied to clipboard

[deploy preview] Experimental UI for flows

Open mstange opened this issue 1 year ago • 1 comments

Deploy preview

Fixes #5178, to a degree.

This adds a flow panel at the bottom of the marker chart.

The panel shows a row per flow once a marker with flow fields is clicked. Clicking a row in the panel makes that flow the active flow and shows its associated flows in the panel. Hovering markers in the flow panel shows a tooltip and arrows.

This PR also adds the following functions that can be called from the console:

  • printFlows()
  • printFlow(1234) (called with flow indexes, for example those from the "incoming context flows" printed by printFlows())
  • selectMarkerOnThread(1234, 56) (called with the marker index and the thread index)

Those aren't that useful anymore; we used them before this PR had any UI.

mstange avatar Nov 06 '24 22:11 mstange

Codecov Report

Attention: Patch coverage is 4.89297% with 311 lines in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (a458f7b) to head (127fa1b). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/marker-data.js 0.00% 215 Missing and 43 partials :warning:
src/actions/profile-view.js 0.00% 20 Missing and 6 partials :warning:
src/utils/window-console.js 15.78% 15 Missing and 1 partial :warning:
src/selectors/flow.js 21.42% 10 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5190      +/-   ##
==========================================
- Coverage   88.57%   87.60%   -0.97%     
==========================================
  Files         308      309       +1     
  Lines       28028    28352     +324     
  Branches     7587     7658      +71     
==========================================
+ Hits        24826    24839      +13     
- Misses       2985     3245     +260     
- Partials      217      268      +51     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 06 '24 22:11 codecov[bot]