profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Ability to change welcome message on `/from-post-message` endpoint

Open nisargjhaveri opened this issue 1 year ago • 1 comments

I'm working on using the https://profiler.firefox.com/from-post-message/ endpoint for an VSCode extension to analyse Android profiles.

I'm able to get it to work with a couple of caveats. Though, I notices that the message on the welcome screen "Importing the profile directly from ⁨Firefox⁩…" can be misleading in this case.

Screenshot 2024-10-24 at 2 49 41 AM

Is it possible to either change it to something generic, or adding an ability to change the string when using in different context, maybe using a query param or something?

┆Issue is synchronized with this Jira Task

nisargjhaveri avatar Oct 23 '24 21:10 nisargjhaveri

Ah right the message isn't great in this case. It's super easy to change at https://github.com/firefox-devtools/profiler/blob/3377d1aa75a00fe1dfed3566daa2d8131b19da19/src/components/app/ProfileLoaderAnimation.js#L23 And add a string in https://github.com/firefox-devtools/profiler/blob/3377d1aa75a00fe1dfed3566daa2d8131b19da19/locales/en-US/app.ftl#L730-L736 (not the other locale files please)

This makes me think that these other locations should be updated too: https://github.com/firefox-devtools/profiler/blob/3377d1aa75a00fe1dfed3566daa2d8131b19da19/src/components/app/AppViewRouter.js#L30-L38 https://github.com/firefox-devtools/profiler/blob/3377d1aa75a00fe1dfed3566daa2d8131b19da19/locales/en-US/app.ftl#L30-L35

julienw avatar Oct 24 '24 09:10 julienw