firefox-devtools
Missing unified string optional values cause errors during marker filtering
When changing the filter string nothing is visibly changing in the marker chart, but when sharing the profile and loading it in a new tab, this error is displayed in the marker chart: Error: index undefined not in UniqueStringArray.
Example profile: https://share.firefox.dev/3yVvZvZ
Julien said on Matrix:
we could check for undefined after https://github.com/firefox-devtools/profiler/blob/662dc4aef2da516b0099bfe9c94c7ffdf34b5200/src/profile-logic/marker-schema.js#L673
┆Issue is synchronized with this Jira Task
can I give it a shot? @fqueze
Sure, go ahead :). (@julienw marked the issue as good first issue so I expect him to reply; sorry for the delay)
@julienw @fqueze Added a small null check.
https://github.com/firefox-devtools/profiler/pull/5125
Hi, is this issue open to contribute? I went thru the last pr against it, will that work? I would like to give it a shot.
Hi @arpit-ayeeee , as far as I know @itsarijitray is still working on it . Also I'd like to highlight just in case you're part of outreachy that this project isn't an outreachy project.
@julienw @fqueze @arpit-ayeeee
Apologies for the delay in my response. I am in the middle of an medical emergency so I am not able to work on this. @julienw you can assign this to @arpit-ayeeee as I am not sure if I will be able to allocate time at moment. Extremely sorry for the delay in my response.
Please @arpit-ayeeee , if you're still up to it! :-) @itsarijitray hope it will get better for you soon!