profiler icon indicating copy to clipboard operation
profiler copied to clipboard

`Edit the profile name` is hard-coded in English

Open flodolo opened this issue 1 year ago • 5 comments

Code here: https://github.com/firefox-devtools/profiler/blob/fb85b0bd057824204bdfcbcb6f06132a53da699f/src/components/app/ProfileName.js#L106

┆Issue is synchronized with this Jira Task

flodolo avatar Aug 26 '24 12:08 flodolo

Hey I would like to help but before proceeding can you tell me why the change is mandatory and what changes do you expect? Just asking so I can infer better and come up with a solution catering to your needs

The goal is to localize the title attribute (in both button and input) as well as the aria-label attribute in the input.

Here is an example of localizing an attribute: https://github.com/firefox-devtools/profiler/blob/fb85b0bd057824204bdfcbcb6f06132a53da699f/locales/en-US/app.ftl#L24-L25 used in https://github.com/firefox-devtools/profiler/blob/fb85b0bd057824204bdfcbcb6f06132a53da699f/src/components/app/AppHeader.js#L46

Please edit only the en-US locale, not the other ones.

Thanks!

julienw avatar Aug 26 '24 16:08 julienw

Hi @PratikThoratNortheastern, are you working on this? If not can I work on this?

unamdev0 avatar Sep 01 '24 14:09 unamdev0

I have not been assigned this task yet.

@flodolo I would like to work on this issue

taiwo2 avatar Oct 17 '24 00:10 taiwo2

I create a draft pr https://github.com/firefox-devtools/profiler/pull/5345. I am not sure how to test it since it will be same as before but i think in general it will fix the issue. Maybe some better naming would be possible as well.

theoniko avatar Jan 27 '25 15:01 theoniko