profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Improve dropped functions UI

Open mstange opened this issue 2 years ago • 2 comments

Production | Deploy preview

Fixes #4678.

┆Issue is synchronized with this Jira Task

mstange avatar Jun 22 '23 19:06 mstange

Codecov Report

Patch coverage: 69.67% and project coverage change: -0.13 :warning:

Comparison is base (eac238a) 88.33% compared to head (f3001f2) 88.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4682      +/-   ##
==========================================
- Coverage   88.33%   88.21%   -0.13%     
==========================================
  Files         299      301       +2     
  Lines       26709    26829     +120     
  Branches     7206     7231      +25     
==========================================
+ Hits        23594    23667      +73     
- Misses       2902     2944      +42     
- Partials      213      218       +5     
Impacted Files Coverage Δ
src/components/app/MenuButtons/Permalink.js 81.81% <ø> (ø)
src/components/app/MenuButtons/index.js 88.17% <ø> (ø)
src/components/shared/StackSettings.js 86.36% <ø> (ø)
src/profile-logic/profile-data.js 93.51% <0.00%> (-0.30%) :arrow_down:
src/utils/flow.js 84.28% <ø> (-0.23%) :arrow_down:
src/components/shared/DroppedFunctionsPanel.js 5.88% <5.88%> (ø)
src/selectors/per-thread/thread.js 91.94% <50.00%> (-3.06%) :arrow_down:
src/actions/profile-view.js 90.13% <57.14%> (-0.37%) :arrow_down:
src/reducers/url-state.js 95.59% <61.29%> (-2.66%) :arrow_down:
src/app-logic/url-handling.js 86.34% <77.27%> (-0.40%) :arrow_down:
... and 7 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 05 '23 20:07 codecov[bot]

This is ready for review now. It's not super polished visually, but I think it's a vast improvement over what we have today. Also, I really want the dropFunctions action for the report generator.

It's also missing some tests.

mstange avatar Jul 05 '23 21:07 mstange