profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Improve performance when inverting or un-inverting the callstack

Open violasong opened this issue 8 years ago • 4 comments

Boris says it's pretty slow. Markus says #337 may help with this.

┆Issue is synchronized with this Jira Task

violasong avatar Jul 21 '17 18:07 violasong

Here is a profile where I invert/uninvert several times: https://perfht.ml/2wfQBxf A lot of time seems to be spent in getCallNodeInfo.

I'm trying to confirm from a prod build.

julienw avatar Sep 15 '17 15:09 julienw

This profile is better: https://perfht.ml/2ydxAsK

Especially we spend time in https://github.com/devtools-html/perf.html/blob/a40a1ec19131e2e09821f8ac0b43fc3a3a6d2186/src/profile-logic/profile-data.js#L640 which isn't especially surprising :)

julienw avatar Sep 15 '17 17:09 julienw

https://perfht.ml/2x7I6Da

Here's that profile zoomed in and data transformed (that was fun).

gregtatum avatar Sep 15 '17 18:09 gregtatum

When looking at https://share.firefox.dev/2TYWD2w clicking the "Full range" button blocks the UI for ~25s on my macbook pro.

fqueze avatar Aug 04 '21 13:08 fqueze