profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Make the IPC tracks hidden by default during the first profile load

Open canova opened this issue 3 years ago • 1 comments

Fixes #3888.

Let's not make them visible by default, so they wouldn't take up a lot of space in the timeline. People still can always make them visible by using the tracks context menu if they are interested in them.

Example profile: production / deploy preview

canova avatar Feb 24 '22 13:02 canova

Codecov Report

Patch coverage: 85.71% and project coverage change: -1.30 :warning:

Comparison is base (36bad68) 88.63% compared to head (c16fa80) 87.33%.

:exclamation: Current head c16fa80 differs from pull request most recent head 671c350. Consider uploading reports for the commit 671c350 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3908      +/-   ##
==========================================
- Coverage   88.63%   87.33%   -1.30%     
==========================================
  Files         293      278      -15     
  Lines       25990    23774    -2216     
  Branches     6998     6272     -726     
==========================================
- Hits        23035    20764    -2271     
- Misses       2749     2771      +22     
- Partials      206      239      +33     
Impacted Files Coverage Δ
src/profile-logic/tracks.js 82.98% <85.71%> (+0.19%) :arrow_up:

... and 147 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 24 '22 13:02 codecov[bot]

When I was working on IPC markers, I had decided to keep this PR open so it could be easier for me to work on them.

But it's been a while since then and I forgot this PR. There is bug-1832144, which depends on this PR to land first. Let's land it now. Rebased it on top of the current main branch.

canova avatar May 10 '23 11:05 canova