profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Add the merge-function-set transform

Open gregtatum opened this issue 3 years ago • 4 comments

This resolves #3761

For profiles with large amounts of merges:

  • This makes the UI more reasonable by grouping the merges.
  • The full profile load no longer kills the browser in how long it takes.
  • There is a slight performance regression per merge, but not too bad. My numbers weren't very scientific.
Operation Profile steps Timing URL
Merge function load profile 11.6s https://share.firefox.dev/32eRabC
Merge function set load profile 0.2s https://share.firefox.dev/3q8K0xG
Merge function apply one transform 168ms https://share.firefox.dev/3q3SXbx
Merge function set apply one transform 218ms https://share.firefox.dev/3GTaAlf

gregtatum avatar Dec 17 '21 17:12 gregtatum

Codecov Report

Merging #3762 (1d10cdd) into main (2214df8) will decrease coverage by 0.00%. The diff coverage is 83.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
- Coverage   87.87%   87.86%   -0.01%     
==========================================
  Files         268      268              
  Lines       22403    22471      +68     
  Branches     5741     5763      +22     
==========================================
+ Hits        19686    19744      +58     
- Misses       2504     2514      +10     
  Partials      213      213              
Impacted Files Coverage Δ
src/components/shared/CallNodeContextMenu.js 88.78% <0.00%> (-0.84%) :arrow_down:
src/profile-logic/transforms.js 92.53% <81.63%> (-0.83%) :arrow_down:
src/reducers/url-state.js 94.68% <95.23%> (-0.02%) :arrow_down:
src/utils/flow.js 84.05% <100.00%> (+0.23%) :arrow_up:
src/utils/uintarray-encoding.js 64.42% <0.00%> (+0.96%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2214df8...1d10cdd. Read the comment docs.

codecov[bot] avatar Dec 17 '21 19:12 codecov[bot]

I still plan on finishing this, was out of office for the holidays.

gregtatum avatar Jan 14 '22 21:01 gregtatum

Any update on this one? I'd like to at least get it out of my review queue if it's not relevant anymore ;-)

flodolo avatar Sep 19 '22 05:09 flodolo

Any update on this one? I'd like to at least get it out of my review queue if it's not relevant anymore ;-)

I removed the r request for you until we finish it.

julienw avatar Sep 19 '22 17:09 julienw