profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Replace the context menu library

Open julienw opened this issue 4 years ago • 0 comments

The context menu library we're using is now unmaintained.

https://www.npmjs.com/package/@szhsin/react-menu might be a good replacement. But we need to test it.

We have some difficult use cases, because we generate some context menus on the fly because of performance reasons (which may not be necessary anymore, possibly?), and there should be no flickering. Also we have different context menus for the same DOM element (think: marker chart, with one canvas but many markers).

Some difficult use cases are:

  • right click somewhere in a panel => the menu opens for that element
  • right click somewhere else in a panel => the menu should open for this new element, and everything works for this new element. Test this in the call tree and and canvas-based charts.

┆Issue is synchronized with this Jira Task

julienw avatar Jul 26 '21 08:07 julienw