profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Clean up the fallback label code for FileIO markers

Open julienw opened this issue 4 years ago • 3 comments

In the following code, we have some fallback code dedicated to FileIO markers: https://github.com/firefox-devtools/profiler/blob/c87e4e9127aa1f2e423dd81712cc4f829cf24e6f/src/profile-logic/marker-schema.js#L279-L289

This doesn't seem necessary nowadays as this could be implemented as a schema. The work here is:

  1. implement in gecko the schema that does this. (or check that it's implemented)
  2. remove the aforementioned fallback code
  3. add migration steps to both gecko and processed profile versioning to add the data to marker schemas from older profiles.
  4. possibly add tests if there's some missing for this case

┆Issue is synchronized with this Jira Task

julienw avatar Jan 15 '21 14:01 julienw

Hi, I want to work on this issue. I will be very grateful if you could help me in solving it!

Jasleen01 avatar Jan 22 '21 12:01 Jasleen01

As we discussed on Matrix, this is probably a bit too complex for a first-time contributor. So this is still up for grabs.

julienw avatar Jan 22 '21 13:01 julienw

Ok sir, got it.. Thanks! :)

Jasleen01 avatar Jan 22 '21 13:01 Jasleen01