profiler icon indicating copy to clipboard operation
profiler copied to clipboard

[wip] Use the built-in connect function rather than explicitConnect

Open gregtatum opened this issue 5 years ago • 1 comments

This is a requirement for #2931. I can't quite get parity with a TypeScript implementation, which used more inference, as Flow has a bug in object type inference. I'm keeping this as a draft until I have TypeScript tests, as I don't want to do a big migration without being absolutely sure it works.

┆Issue is synchronized with this Jira Task

gregtatum avatar Nov 16 '20 23:11 gregtatum

Codecov Report

Merging #3063 (ed379e9) into main (4e49b61) will decrease coverage by 0.20%. The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3063      +/-   ##
==========================================
- Coverage   88.14%   87.94%   -0.21%     
==========================================
  Files         240      241       +1     
  Lines       19083    19130      +47     
  Branches     4871     4876       +5     
==========================================
+ Hits        16821    16823       +2     
- Misses       2095     2140      +45     
  Partials      167      167              
Impacted Files Coverage Δ
src/test/types/react-redux-connect.js 0.00% <0.00%> (ø)
src/test/types/react-redux-explicit-connect.js 0.00% <ø> (ø)
src/utils/flow.js 74.32% <0.00%> (-9.01%) :arrow_down:
src/components/app/DragAndDrop.js 80.43% <100.00%> (+0.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e49b61...ed379e9. Read the comment docs.

codecov[bot] avatar Nov 16 '20 23:11 codecov[bot]