profiler
profiler copied to clipboard
firefox-devtools
Inconsistent application of multiple search terms
In the search fields in our various panes, you can use commas to search for multiple strings. However, it seems that different panes have different interpretations of "searching for multiple strings":
- If I search the call tree for
addon,extension, I only get call stacks where both the string "addon" and the string "extension" is present in the stack: https://perfht.ml/2QjbZtB - If I search the marker chart for
ipcin,display, I get markers that match just one of the terms: https://perfht.ml/2QmNlrU
Please choose either OR or AND and make it consistent.
┆Issue is synchronized with this Jira Task
The multiple search for markers is quite recent.
Which way do you think would be more useful for you Markus? I think the AND behavior is more useful and that's why I did it for the calltree initially, because we can always get a OR behavior by searching twice. What do you think?
I'm not sure - ideally I'd want access to both :) But if only one is available, it should really be consistent.
I think the AND behavior is more useful and that's why I did it for the calltree initially, because we can always get a OR behavior by searching twice.
I actually disagree with the "searching twice" argument. In the first profile link given above, I was actually trying to find out "how many samples are we spending in extension-related code?" Some of those samples only have the word "addon" in their stack and some only have the word "extension" in their stack, but some have both. So I can't really just add samples with "addon" + samples with "extension", because I might count the samples in the overlap twice. I guess I could add the two and then subtract samples with "addon,extension"...
I see, thanks for the feedback! I think I'd implement the AND behavior for both, but we should find a better way. I think we actually had some plans some years ago but never really looked at it since then.
Was recently trying to find specific markers that matched a part of a URL while ignoring the other markers and having an AND would be very useful!
Can we remove the comma feature and only use a regex, then users can craft all kinds of crazy searches without inventing lots of UI to handle it. This would be similar to how searchfox works.
