profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Memory track hover dot affects scrollable size in header

Open mstange opened this issue 6 years ago • 3 comments

Steps to reproduce:

  1. Go to https://perfht.ml/2CpYC2S
  2. Scroll down in the header to the very bottom.
  3. Hover the memory track for Web Content (2/2) in the right half of the track, where the orange graph is very low.
  4. Without moving the mouse, scroll down.
  5. Unhover.

Expected results: At step 4 you shouldn't be able to scroll down more. So that step 5 doesn't make the header jerk.

mstange avatar Jan 16 '19 16:01 mstange

I think we need to make the graph overflow:hidden so that the dot doesn't extend beyond the graph's size. Additionally, we need to shift the graph itself a little bit inwards so that the dot isn't clipped off. We already have code for this inward shifting:

https://github.com/firefox-devtools/profiler/blob/5881060bdf60331598dae5684331a37dc74ff8f2/src/components/timeline/TrackMemoryGraph.js#L149-L155

mstange avatar Jun 10 '22 14:06 mstange

I've tried to reproduce this issue but I don't get the same expected results in my Firefox browser. Has it been resolved?

Tch4lla avatar Sep 15 '22 21:09 Tch4lla

I can still reproduce this. Make sure that your mouse is in the "low" part of the orange graph while you scroll down, so that the "hover dot" is as low as possible.

mstange avatar Sep 15 '22 22:09 mstange