devtools-core icon indicating copy to clipboard operation
devtools-core copied to clipboard

Cleanup landing page tab UI

Open jasonLaster opened this issue 7 years ago • 8 comments

  • The landing page tabs could line up nicely with the left sidebar tabs if we update the vertical heights.
  • also we can cleanup to focus border to be less obnoxious

Should be easy to do.

screen shot 2017-01-06 at 12 05 06 pm

jasonLaster avatar Jan 06 '17 17:01 jasonLaster

I see a great opportunity to use CSS grids here :)

nchevobbe avatar Jan 09 '17 17:01 nchevobbe

Oh nice. Would love to see that!

Let's get that in there On Mon, Jan 9, 2017 at 12:34 PM Nicolas Chevobbe [email protected] wrote:

I see a great opportunity to use CSS grids here :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devtools-html/devtools-core/issues/72#issuecomment-271350072, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPiYqegSFSlncopUUz66awmv4p0Ranbks5rQm-2gaJpZM4Lc6Dk .

jasonLaster avatar Jan 10 '17 01:01 jasonLaster

screen shot 2017-01-12 at 13 56 25

Using grid is nice here :) But I'm not pleased with the alignement of the "Firefox" element with the tab item on the right. I don't see an obvious solution to align those since the tab on the right has a variable height (if the title or the URL is long enough, they can be multiline)

I'll try to iterate a bit on the page

nchevobbe avatar Jan 12 '17 13:01 nchevobbe

Hmm, one solution would be to right align the URL on the same line as the title.

This way with a smaller font size, we should be fine. Also if you want you can do two lines for the URL:

host
url part (truncated potentioally)

e.g

http://localhost:6006
?selectedind=LandingPage&MoreStuff ...

jasonLaster avatar Jan 12 '17 14:01 jasonLaster

Yeah, I thought about it, the problem is that the title also can be multiline. This can be cropped too, I wonder how it would look

nchevobbe avatar Jan 12 '17 15:01 nchevobbe

But yeah, one thing I'll try is too have a fixed height (the same one) for the tab element and the connection one, and do some text-overflow on both the title and the URL

nchevobbe avatar Jan 12 '17 15:01 nchevobbe

sounds good.

Remember, this is nice... but not that important :)

jasonLaster avatar Jan 12 '17 15:01 jasonLaster

Do we still want this?

AnshulMalik avatar Dec 30 '18 16:12 AnshulMalik