devtools-core
devtools-core copied to clipboard
TCP Port should be configurable
This is a good starting off point
diff --git a/packages/devtools-launchpad/src/development-server.js b/packages/devtools-launchpad/src/development-server.js
index 53d7cf4..6e0cdd0 100755
--- a/packages/devtools-launchpad/src/development-server.js
+++ b/packages/devtools-launchpad/src/development-server.js
@@ -129,7 +129,10 @@ function startDevServer(devConfig, webpackConfig, rootDir) {
if (!getValue("firefox.webSocketConnection")) {
const firefoxProxy = require("../bin/firefox-proxy");
- firefoxProxy({ logging: getValue("logging.firefoxProxy") });
+ firefoxProxy({
+ logging: getValue("logging.firefoxProxy"),
+ tcpPort: getValue("firefox.tcpPort")
+ });
}
Maybe this one will help me, sadly i still feeling unfamiliar with the code base.
hmm, what's your issue again? if it works w/ websocket then just make that the default for you
Am i wrong?
i'm not sure... we all get the json/list error because it's trying to fetch the tabs for a firefox that's not necessarily open. The key is to launch a firefox that you can then inspect, there are two ways. open firefox yourself and follow these steps: https://github.com/devtools-html/debugger.html/blob/master/docs/getting-setup.md
- use the launch firefox button which might not work for windows/linux
the button under the hood is doing the same thing too: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-launchpad/bin/firefox-driver.js#L41-L70
it's just a helper :)