devtools-core icon indicating copy to clipboard operation
devtools-core copied to clipboard

yarn run firefox - linux

Open jasonLaster opened this issue 8 years ago • 1 comments

yarn run firefox cannot find the firefox path on linux

here is where selenium does the lookup.

here's a patch to think about extending the $PATH variable

diff --git a/packages/devtools-launchpad/bin/firefox-driver.js b/packages/devtools-launchpad/bin/firefox-driver.js
index 3a0d911..fd3c4e8 100755
--- a/packages/devtools-launchpad/bin/firefox-driver.js
+++ b/packages/devtools-launchpad/bin/firefox-driver.js
@@ -42,6 +42,11 @@ function binaryArgs() {
 }

 function firefoxBinary() {
+  // => binary path...
+  // we might need to do something where we append to the path
+  // maybe like this but different
+  //  process.env.PATH += `:${__dirname}`;
+
   let binary = new firefox.Binary();

jasonLaster avatar Feb 23 '17 16:02 jasonLaster

I think it's now handled by selenium?

AnshulMalik avatar Dec 30 '18 16:12 AnshulMalik