Remove webSocketConnection option

[AnshulMalik]

We no longer need firefox proxy since we can just use sockets now. So we can get rid of webSocketConnection and the code related to this option.

It is currently used at these places: https://github.com/devtools-html/devtools-core/search?utf8=%E2%9C%93&q=webSocketConnection&type=

[chrlsstcky]

I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used?

[AnshulMalik]

Yes, that's right. Assume that sockets will always be used. So no longer need to check.

On Mon, Dec 31, 2018, 02:10 Charles Stocky <[email protected] wrote:

I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devtools-html/devtools-core/issues/1118#issuecomment-450585264, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdZvZ8fh2tIz65TuJWa6sh5nEBDPlJzks5u-SSygaJpZM4ZjiAO .

[chrlsstcky]

/claim

[claim[bot]]

Thanks for claiming the issue! :wave:

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

:fox_face: Debugger team!

[AnshulMalik]

Hey @chrlsstcky Do you need any help on this? Please feel free to ask in slack.