devtools-core icon indicating copy to clipboard operation
devtools-core copied to clipboard

Only render the SplitBox draggable when nothing is collapsed.

Open lijunle opened this issue 6 years ago • 2 comments

Associated Issue:

The debugger is showing scrollbar when collapse the panes.

image

Besides, currently, when the pane is collapsed, hover on the edge (dragger), the cursor is still showing as "draggable", which is confusing.

Summary of Changes

  • It should not render the dragger when any pane is collapsed.

Test Plan

I FAILED TO RUN ANY TEST. THE DEV IS VERY NOT FRIENDLY. 😞

Screenshots/Videos (OPTIONAL)

lijunle avatar May 04 '18 19:05 lijunle

Thanks for the PR and raising the issue!

@jasonLaster the fix makes sense I think could you review?

juliandescottes avatar May 08 '18 08:05 juliandescottes

Thanks. I'll take a look!

jasonLaster avatar May 21 '18 16:05 jasonLaster