firecracker

firecracker copied to clipboard

Add ACPI support for x86_64

1

## Changes Introduce ACPI support for x86_64. ## Reason Introducing ACPI will let us do a couple of things: * Get rid of the i8042 (minimal) emulation. We will be...

bchalios

## Changes - Enabled topology tests for aarch64 - Added hwloc topology tests ## License Acceptance By submitting this pull request, I confirm that my contribution is made under the...

ShadowCurse

Derived from discussion here: https://github.com/firecracker-microvm/firecracker/pull/3654#discussion_r1184696354 As `/sys/devices/virtual/dmi/id/bios_release` is only available since kernel 5.8, it uses `dmidecode` command instead. After the end of kernel 4.14 support, we need to drop the...

zulinx86

Virtio-net: implement support of VIRTIO_NET_F_MRG_RXBUF

7

Per comment: https://github.com/firecracker-microvm/firecracker/blob/99a026756c406d1c7f60c5c9f6685adcab1229e7/devices/src/virtio/net.rs#L153-L154 virtio-net implementation in firecracker does not support VIRTIO_NET_F_MRG_RXBUF. The VIRTIO_NET_F_MRG_RXBUF allows for much finer memory management that the existing one that relies on humongous 68K (17 pages)...

wkozaczuk

Resolve untracked TODOs

5

There a large number of relatively simple `TODO` comments in the code base, most do not have their own issues. This issue exist to track these. To contribute, submit a...

JonathanWoollett-Light

Run rustdoc tests

6

Running `test_coverage.py` does not take into account doc tests in the coverage, `cargo test` does not run them. Using `sudo ./tools/devtool shell -p` and running `cargo test` also ignores doc...

JonathanWoollett-Light

Use `core::arch::x86_64::has_cpuid`

1

It would be preferable to use the more general [`core::arch::x86_64::has_cpuid`](https://doc.rust-lang.org/core/arch/x86_64/fn.has_cpuid.html) to check for CPUID support. Blocked on: https://github.com/rust-lang/rust/issues/48556

JonathanWoollett-Light

Use `split_array_ref`

3

Use [`::split_array_ref`](https://doc.rust-lang.org/std/primitive.array.html#method.split_array_ref) to improve `src/cpuid/src/intel/mod.rs` `IntelCpuid::default_brand_string`. Blocked on https://github.com/rust-lang/rust/issues/90091

JonathanWoollett-Light

[Improvement] Add an integration test for checking that PRs do not leave unchecked files behind

4

# Describe the bug We have been having 2 cases in the last 2 weeks where `tests/host_tools/uffd/Cargo.lock` was left behind and not checked in as part of the PR changes...

dianpopa

Add integration test for memory performance guest vs host

8

Add a test case which will check if memory performance of the guest vs host. Both guest and host will be tested having the same shape for accurate results.

goandrei