firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Have `tools/devtool fmt` also run `black` and mdformat

Open roypat opened this issue 9 months ago • 1 comments

Reason

Previously, it would only run cargo fmt. Now, it will please all formatting rules we have in our CI, e.g. also include python and markdown formatters.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • [ ] Commits meet contribution quality standards.

  • [ ] This functionality cannot be added in rust-vmm.

roypat avatar May 08 '24 14:05 roypat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.13%. Comparing base (9adc059) to head (8e2c910).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4608   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files         255      255           
  Lines       31267    31267           
=======================================
  Hits        25682    25682           
  Misses       5585     5585           
Flag Coverage Δ
4.14-c5n.metal 79.62% <ø> (-0.01%) :arrow_down:
4.14-c7g.metal ?
4.14-m5n.metal 79.62% <ø> (+<0.01%) :arrow_up:
4.14-m6a.metal 78.85% <ø> (+<0.01%) :arrow_up:
4.14-m6g.metal 76.68% <ø> (ø)
4.14-m6i.metal 79.61% <ø> (ø)
4.14-m7g.metal 76.68% <ø> (?)
5.10-c5n.metal 82.15% <ø> (+<0.01%) :arrow_up:
5.10-c7g.metal ?
5.10-m5n.metal 82.14% <ø> (+<0.01%) :arrow_up:
5.10-m6a.metal 81.44% <ø> (ø)
5.10-m6g.metal 79.46% <ø> (ø)
5.10-m6i.metal 82.13% <ø> (+<0.01%) :arrow_up:
5.10-m7g.metal 79.46% <ø> (?)
6.1-c5n.metal 82.14% <ø> (-0.01%) :arrow_down:
6.1-m5n.metal 82.13% <ø> (ø)
6.1-m6a.metal 81.45% <ø> (ø)
6.1-m6g.metal 79.45% <ø> (ø)
6.1-m6i.metal 82.13% <ø> (ø)
6.1-m7g.metal 79.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 14:05 codecov[bot]