firecracker
firecracker copied to clipboard
fix(net): Apply only supported TAP offloading features
Changes
Checking what offload features are supported by virtio driver and apply only them to TAP device ...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.
PR Checklist
- [x ] If a specific issue led to this PR, this PR closes the issue.
- [x ] The description of changes is clear and encompassing.
- [ x] Any required documentation changes (code and docs) are included in this PR.
- [ ] API changes follow the Runbook for Firecracker API changes.
- [ ] User-facing changes are mentioned in
CHANGELOG.md
. - [ x] All added/changed functionality is tested.
- [ ] New
TODO
s link to an issue. - [ ] Commits meet contribution quality standards.
- [ ] This functionality cannot be added in
rust-vmm
.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
826831d
) 81.52% compared to head (ed54276
) 81.54%. Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4386 +/- ##
==========================================
+ Coverage 81.52% 81.54% +0.02%
==========================================
Files 241 241
Lines 29296 29338 +42
==========================================
+ Hits 23883 23925 +42
Misses 5413 5413
Flag | Coverage Δ | |
---|---|---|
4.14-c5n.metal | 78.83% <100.00%> (+0.03%) |
:arrow_up: |
4.14-c7g.metal | ? |
|
4.14-m5d.metal | ? |
|
4.14-m5n.metal | 78.82% <100.00%> (+0.03%) |
:arrow_up: |
4.14-m6a.metal | 77.94% <100.00%> (+0.03%) |
:arrow_up: |
4.14-m6g.metal | 76.90% <100.00%> (+0.03%) |
:arrow_up: |
4.14-m6i.metal | 78.81% <100.00%> (+0.03%) |
:arrow_up: |
4.14-m7g.metal | 76.90% <100.00%> (+0.03%) |
:arrow_up: |
5.10-c5n.metal | 81.51% <100.00%> (+0.02%) |
:arrow_up: |
5.10-c7g.metal | ? |
|
5.10-m5d.metal | ? |
|
5.10-m5n.metal | 81.50% <100.00%> (+0.02%) |
:arrow_up: |
5.10-m6a.metal | 80.72% <100.00%> (+0.03%) |
:arrow_up: |
5.10-m6g.metal | 79.83% <100.00%> (+0.03%) |
:arrow_up: |
5.10-m6i.metal | 81.50% <100.00%> (+0.02%) |
:arrow_up: |
5.10-m7g.metal | 79.83% <100.00%> (+0.03%) |
:arrow_up: |
6.1-c5n.metal | 81.51% <100.00%> (+0.02%) |
:arrow_up: |
6.1-c7g.metal | ? |
|
6.1-m5d.metal | ? |
|
6.1-m5n.metal | 81.50% <100.00%> (+0.02%) |
:arrow_up: |
6.1-m6a.metal | 80.72% <100.00%> (+0.03%) |
:arrow_up: |
6.1-m6g.metal | 79.83% <100.00%> (+0.03%) |
:arrow_up: |
6.1-m6i.metal | 81.50% <100.00%> (+0.02%) |
:arrow_up: |
6.1-m7g.metal | 79.83% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing this one. I cherry-picked Nikita's commit in https://github.com/firecracker-microvm/firecracker/pull/4680.